This repository was archived by the owner on Sep 9, 2025. It is now read-only.
Fix typed splat function parameters in Python.#478
Closed
bm-w wants to merge 1 commit intogithub:mainfrom
Closed
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with the Tree-sitter Python grammar by explicitly eliding the identifier node type in typed_parameter nodes. The changes ensure that list_splat_pattern and dictionary_splat_pattern are not erroneously matched, resolving stack graph generation errors.
- Updated tests to validate proper behavior for typed splat function parameters.
- Added two test cases to confirm correct handling of both *args and **kwargs.
Files not reviewed (1)
- languages/tree-sitter-stack-graphs-python/src/stack-graphs.tsg: Language not supported
bm-w
force-pushed
the
bm-w/fix-python-typed-splats
branch
from
a843137 to
07d950a
Compare
Contributor
|
The github/stack-graphs repository is no longer being maintained. As per #502, I'm closing all issues and pull requests before archiving the repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses issue #476.
Eliding the
identifiernode type in the stanza query allows it to erroneously matchlist_splat_patternordictionary_splat_patternwhen those appear within atyped_parameter. This causes the stack graph generation to fail with an error:The fragment of the parsed Tree-sitter tree for such a parameter is:
As of v0.23.5 of the Python grammar,
typed_parametermay containidentifieror either of the*_splat_patternnode types. As such, making theidentifiernode type explicit fixes the issue precisely without introducing other problems.